Quantcast
Channel: Rainmeter Forums
Viewing all articles
Browse latest Browse all 1640

Community Plugins & Addons • Re: Finalshot

$
0
0
Version 1.3

Version 1.3 is here with much more features.

Link:
https://github.com/NSTechBytes/FinalShot
1. Bug: your plugin doesn't handle the nested variable syntax well. Comparison between similar plugins...

a) RunCommand:

Code:

[Variables]State=0Index=1Count=2Bangs0=[!UpdateMeasure SomeMeasure][!CommandMeasure SomeMeasure "Run"]Bangs1=[!UpdateMeter SomeMeter][!Redraw][Rainmeter]Update=1000AccurateText=1DynamicWindowSize=1---Measures---[SomeMeasure]Measure=PluginPlugin=RunCommandProgram=PowerShellParameter=exitOutputType=ANSIState=ShowUpdateDivider=-1FinishAction=[!SetVariable Index (#Index#+1)][!SetVariable State (#Index#<#Count#?0:1)][!Log "State = #State#|[#State], Index = #Index#|[#Index], Count = #Count#|[#Count]"][#Bangs[#State]]DynamicVariables=1---Meters---[SomeMeter]Meter=ImageW=100H=100SolidColor=0,0,0,128UpdateDivider=-1LeftMouseUpAction=[!SetVariable State 0][!SetVariable Index 1][!UpdateMeasure SomeMeasure][!UpdateMeter SomeMeter][!Redraw][!CommandMeasure SomeMeasure "Run"]DynamicVariables=1
RunCommand.jpg
b) Finalshot:

Code:

[Variables]State=0Index=1Count=2Bangs0=[!UpdateMeasure SomeMeasure][!CommandMeasure SomeMeasure "-ps"]Bangs1=[!UpdateMeter SomeMeter][!Redraw][Rainmeter]Update=1000AccurateText=1DynamicWindowSize=1---Measures---[SomeMeasure]Measure=PluginPlugin=FinalshotPredefX=#CURRENTCONFIGX#PredefY=#CURRENTCONFIGY#PredefWidth=#CURRENTCONFIGWIDTH#PredefHeight=#CURRENTCONFIGHEIGHT#SavePath=#CURRENTPATH#Screenshot#Index#.pngUpdateDivider=-1ScreenshotFinishAction=[!SetVariable Index (#Index#+1)][!SetVariable State ([#Index]<[#Count]?0:1)][!Log "State = #State#|[#State], Index = #Index#|[#Index], Count = #Count#|[#Count]"][#Bangs[#State]]DynamicVariables=1---Meters---[SomeMeter]Meter=ImageW=100H=100SolidColor=0,0,0,128UpdateDivider=-1LeftMouseUpAction=[!SetVariable State 0][!SetVariable Index 1][!UpdateMeasure SomeMeasure][!UpdateMeter SomeMeter][!Redraw][!CommandMeasure SomeMeasure "-ps"]DynamicVariables=1
Finalshot.jpg
So basically, I'm trying to sequentially "self run" the plugin's action by incrementing Index up to Count. In the case of your plugin, the sequence is ran an incorrect number of times because the nested variables are not evaluated properly.

2. Suggestion: Add the ability to capture multiple screenshots to your plugin via an option or a parameter to the plugin command (a numeric suffix could be added to the save path to ensure the screenshots are saved to differemt files).

3. Documentation: Add the ScreenshotFinishAction option to the documentation from GitHub, since at this time the option is only present in the example skin there (the option could be shortened to just FinishAction, just like for other similar plugins).

Statistics: Posted by Yincognito — 24 minutes ago



Viewing all articles
Browse latest Browse all 1640

Trending Articles